search

kennethormandy / utility-opentype

Simple, CSS utility classes for advanced typographic features.
http://utility-opentype.kennethormandy.com
MIT License
498 stars 21 forks source link

Smcp Small Caps #8

Closed typometre closed 8 years ago

typometre commented 8 years ago

The smcp class must'nt have the c2c feature settings which got its own class.

As a fallback for smcp, use font-variant:small-caps

kennethormandy commented 8 years ago

Hey, thanks very much for the Pull Request. .smcp doesn’t actually have Caps to Small Caps enabled, though. I’m actually explicitly disabling it with the 0:

/* Enable `onum` and `smcp`, disable `c2sc` */
font-feature-settings: "onum", "smcp", "c2sc" 0;

The font-variant: small-caps; property was omitted on purpose. You can read more about why I did that in the Small Caps section of the docs.

Also—just for future reference—the correct file to edit would be the index.css file in the root of the project. Sorry, this is a common point of confusion whenever it’s necessary to include the compiled CSS in the repo. I will try to improve the contributing documentation for that with #9.

I’m going to close this PR, but feel free to let me know if I’ve misunderstood anything. Thanks very much for taking the time to put this together anyway.