Pendulum 2.0.2 compatibility

kennethreitz / maya

Datetimes for Humans™

MIT License

3.41k stars 199 forks source link

Pendulum 2.0.2 compatibility #161

Closed ViktorHaag closed 5 years ago

ViktorHaag commented 6 years ago

Does the minimal work required to get maya working with pendulum 2.0.2, and run the test suite clean on py2.7 and py3.6.

Possible area for improvement:

make better use of pendulum's Duration class for parsed duration strings, and not assume that everything passed back by pendulum is a DateTime
be more robust around MayaInterval parsing to cope with strings that have a duration as the starting component, as well as the ending component

Addresses issue #160

timofurrer commented 6 years ago

Thanks for this first step :tada:

Do you know of any semantic changes in pendulum 2.0 which would break mayas API?

ViktorHaag commented 6 years ago

I'm sorry, I don't -- my only knowledge of pendulum is through use of maya, and my use of maya is quite casual; the fixes to get maya at least testing clean with pendulum 2.0.2 seemed pretty straightforward, but I didn't do more investigation than just that.

gwerbin commented 5 years ago

The list of 2.0.0 changes is here: https://github.com/sdispater/pendulum/releases/tag/2.0.0

The 2.0.2 changes are just bug fixes.

luisdavim commented 5 years ago

any updates on this one?

timofurrer commented 5 years ago

Unfortunately, not from my side. I'll find some time tomorrow to have a look at this!

timofurrer commented 5 years ago

I'm closing this PR in favor of #166 🎉