kennethreitz / pytheory

Music Theory for Humans.
1.46k stars 76 forks source link

NamedTuple Chord #25

Open pylang opened 5 years ago

pylang commented 5 years ago

First off - great, fun library.

Your example of the C-chord in some tuning:

>>> print(c_chord.fingering(fretboard=fretboard))
(0, 0, 0, 3, 3, 3)

It was not clear which tuning this was, but modifying your example to standard tuning, the C-chord could be:

>>> print(c_chord.fingering(fretboard=fretboard))
(0, 3, 2, 0, 1, 0)

or is the orientation reversed?

>>> print(c_chord.fingering(fretboard=fretboard))
(0, 1, 0, 2, 3, 0)

You can see the uncertainty in both tuning and orientation. I think returning a namedtuple would clear up these confusions:

>>> print(c_chord.fingering(fretboard=fretboard))
Fingering('E'=0, 'A'=3, 'D'=2, 'G'=0, 'B'=1, 'e'=0)
pylang commented 4 years ago

This was @kennethreitz's project. What happened?

bisguzar commented 4 years ago

Hi @pylang ,Kenneth just moved all of his projects to volunteer developers. The new maintainer of this project is @Zelgius

kennethreitz commented 7 months ago

This is a good idea! Sorry that I'm just seeing this