kennethreitz / records

SQL for Humans™
https://pypi.python.org/pypi/records/
ISC License
7.16k stars 574 forks source link

Flaws of current `.travis.yml` test suite #139

Closed vlcinsky closed 6 years ago

vlcinsky commented 6 years ago

Current test suite as defined in travis.yml and Makefile has couple of problems:

Proposal for fix is:

vlcinsky commented 6 years ago

https://github.com/kennethreitz/records/pull/140/commits/61b2b68bd5bbbb58f9d47e0e6799f07f61db2f1c is fixing issue with setup.py containing utf-8 encoded chars, which were failing when building the package under python 2.7.

Older version of .travis was not detecting this error as it probably did not build the package and used it in development mode.

vlcinsky commented 6 years ago

See #141 Testing under Python 2.6 revealed: