Closed vlcinsky closed 6 years ago
https://github.com/kennethreitz/records/pull/140/commits/61b2b68bd5bbbb58f9d47e0e6799f07f61db2f1c is fixing issue with setup.py
containing utf-8 encoded chars, which were failing when building the package under python 2.7.
Older version of .travis
was not detecting this error as it probably did not build the package and used it in development mode.
See #141 Testing under Python 2.6 revealed:
Current test suite as defined in
travis.yml
andMakefile
has couple of problems:Makefile
requiremake
, which is not always available under Windows making test setup more difficultpipenv
brings problems:Pipfile
installs dependencies, which shall be installed withrecords
package, effectively hiding possible problems insetup.py
requirements (e.g.setup.py
omitting important dependency, which shall be installed by it).pytest
installedProposal for fix is:
pipenv
for testing (Pipfile.lock
is not used, requirements shall be defined bysetup.py
sodefault
section inPipfile
shall be empty or only with-e .
) Vulnerability to pypi python package updates can be considered as positive feature (detecting real life cases, which shall work well).travis.yml
totox