search

kennethreitz / records

SQL for Humans™
https://pypi.python.org/pypi/records/
ISC License
7.15k stars 570 forks source link

Add title and extension to license #71

Closed waldyrious closed 8 years ago

waldyrious commented 8 years ago

The title is not strictly required, but it's useful metadata, and part of the recommended license template text (see http://choosealicense.com/licenses/isc/ and https://opensource.org/licenses/isc-license)

The extension helps with the display of the license on github (it activates text wrapping)

waldyrious commented 8 years ago

@kennethreitz any feedback?

kennethreitz commented 8 years ago

I don't find this useful. But, thank you :)

waldyrious commented 8 years ago

I respect your decision, but I'd me remiss if I didn't present the reasoning in more detail. Paraphrasing what I said elsewhere:

While not required, there are various ways that adding the title can be useful. One is to make it clearer what license is actually being used (e.g. to quickly verify whether a project's license is among those vetted by the relevant FOSS organizations). It also improves searching (especially since licenses often use very similar language). Additionally, this can serve as a fast early check for content-based license matchers. And I'm sure there are other reasons I'm missing.

kennethreitz commented 8 years ago

Oh, I fully understand the reasoning. I actually prefer that people respect the actual text of license, and the name of the source of the contract is a distraction from that.

The metadata is available elsewhere in the project (in setup.py).

I may change my mind later.

waldyrious commented 8 years ago

Got it. I just wanted to make sure the omission was intentional even considering those potential downsides 👍

waldyrious commented 8 years ago

By the way, would you be ok with just adding the extension? The way the license is currently displayed on the Github interface is quite inconvenient, and adding the extension would activate text wrapping.

kennethreitz commented 8 years ago

Nope. Thank you for the suggestion, though.

kennethreitz commented 8 years ago

Line-wrapping could be manually added, though.

waldyrious commented 8 years ago

Line-wrapping could be manually added, though.

Right, that works too. I'll send another PR then.

kennethreitz commented 8 years ago

I appreciate your diligence. I'm extremely picky and intentional about this stuff :)

waldyrious commented 8 years ago

I can tell :) Thanks for bearing with me, and btw I'm glad this exchange is now on record, as it makes your intentionality explicit ;)

kennethreitz commented 8 years ago

Of course, little of it matters at all. I just have strong preferences.