search

kennethreitz / responder

A familiar HTTP Service Framework for Python.
http://responder.kennethreitz.org/
Other
3.59k stars 218 forks source link

Potential code quality improvements #435

Closed pnijhara closed 6 months ago

pnijhara commented 4 years ago

I forked this repo and ran a DeepSource analysis over it. There:

Link to .deepsource.toml configuration file that was added to the forked repo for running DeepSource analysis can be found here

Which of these issues you would consider high priority, and which ones would you want to ignore or consider false-positive?

I can send a PR with some fixes if you want. You can also activate this analysis on your own, and have it triggered on each PR if you integrate DeepSource in the repo

Disclaimer: I work for DeepSource

pnijhara commented 4 years ago

cc @taoufik07 @ken-reitz What do you think?

taoufik07 commented 4 years ago

Hey @pnijhara, thanks for this tool ! for now let's just create PRs to fix the potential code quality improvements, the security and bug issues are on high priority.

pnijhara commented 4 years ago

Sure! I will open issues for discussion on security and bug-risk issues.

kennethreitz commented 10 months ago

I'm going to close this, for tracking

kennethreitz commented 10 months ago

I can send a PR with some fixes if you want.

that would be great!

pnijhara commented 10 months ago

@kennethreitz do you want me to work on this?

kennethreitz commented 10 months ago

sure!