search

kennethreitz / responder

A familiar HTTP Service Framework for Python.
http://responder.kennethreitz.org/
Other
3.59k stars 218 forks source link

Missing uvloop on default setup #449

Closed waghanza closed 3 years ago

waghanza commented 3 years ago

Hi,

I can see that uvicorn is required in https://github.com/taoufik07/responder/blob/b32eda70d2a36b4014388d6eb226448ef0591d33/setup.py#L26

However, starting from uvicorn 0.12 it setup process has changed https://github.com/encode/uvicorn/blob/master/CHANGELOG.md#changed-1

Regards,

/cc @tomchristie @taoufik07 @kennethreitz42

I had to force uvicorn[standard] in my requirements.txt in https://github.com/the-benchmarker/web-frameworks/pull/3364 to have uvloop

The start command is

gunicorn  \
  --log-level warning  \
  --bind 0.0.0.0:3000  \
  --reuse-port  \
  --workers $(nproc)  \
  --worker-class uvicorn.workers.UvicornWorker \
    server:app
taoufik07 commented 3 years ago

Thank you @waghanza !

I've made a PR https://github.com/taoufik07/responder/pull/450, is it possible to check if it fixes the problem for you ?

waghanza commented 3 years ago

seems ok for me https://the-benchmarker.semaphoreci.com/jobs/dd99b167-c088-4516-9224-ad69f34924ed @taoufik07

could you ping me when release ?

taoufik07 commented 3 years ago

@waghanza Thank you, A new release v20.7 has been issued !