search

kennycason / ultimate_tictactoe

Ultimate Tic Tac Toe - HTML5
53 stars 24 forks source link

User friendly game #13

Open acquenm opened 5 years ago

acquenm commented 5 years ago

I added a bootstrap package for a user-friendly environment. Please approve my pull request for my project in school. Thanks a lot :)

danimesq commented 5 years ago

@kennycason

kennycason commented 5 years ago

@acquenm @DaniellMesquita @JaisonMaceda, this PR seems to include a lot of extra stuff that isn't relevant to the game itself or that could be included from a major CDN. Do you have any screenshots of what the game looks like after your change? My worry at first glance is that you may be uploading spam or some form of attack/hack to my repository.

I do like some of the typos/minor fixes on the index html page and would be willing to accept a PR if it is sized down to a more reasonable size. :)

Also, I don't mind people reaching out to me on my personal FB account, but submitting a PR is good enough, there is not need to alert my on my personal account (unless you just want to meet/chat, or if i take wayyy too long to respond on GitHub.

Thanks, Kenny

kennycason commented 5 years ago

I saw another PR from two days ago that seems more reasonable and accomplishes something similar: https://github.com/kennycason/ultimate_tictactoe/pull/14/files

I will pull that one down and check it out.

acquenm commented 5 years ago

@kennycason, thank you sir for taking the time to check our pull requests. Sorry for the inconvenience we have caused.