kennydude / zxing-lib

NOT MAINTAINED -- Android ZXing Library. Embeddable in apps really easily
83 stars 37 forks source link

Sample App #4

Open ened opened 11 years ago

ened commented 11 years ago

A sample app for this library would be fantastic. (of course, along with the usual suspects like a maven pom.xml and the addition of gradle files).

Maybe you could re-organize the project into

/
/library
/sample

Similar to https://github.com/JakeWharton/Android-ViewPagerIndicator/. Then see how to go from there. :)

kennydude commented 11 years ago

I could do, but this whole project is a mess really :')

It's main purpose was to embed scanning in my apps as it would have been tricky to work with Intents.

99.999% of cases should use Intents

On 14 July 2013 15:04, Sebastian Roth notifications@github.com wrote:

A sample app for this library would be fantastic. (of course, along with the usual suspects like a maven pom.xml and the addition of gradle files).

Maybe you could re-organize the project into

/ /library /sample

Similar to https://github.com/JakeWharton/Android-ViewPagerIndicator/. Then see how to go from there. :)

— Reply to this email directly or view it on GitHubhttps://github.com/kennydude/zxing-lib/issues/4 .

ened commented 11 years ago

Not that I want to place rants in your project... but:

My colleague and me never understood the real reason behind the entire qr-only-as-intent decision. We have fragments now and it can't be that hard to migrate. It would open up huge flexibility for lots of apps.

Most importantly, the user experience with intents is not optimal.

Yes this might be 0.001% of the usecases.

Hence I for hope for this library. I'll take a look into the code soon. :-) Thanks for this project anyway.

On Jul 14, 2013, at 22:09, Joe Simpson notifications@github.com wrote:

I could do, but this whole project is a mess really :')

It's main purpose was to embed scanning in my apps as it would have been tricky to work with Intents.

99.999% of cases should use Intents

On 14 July 2013 15:04, Sebastian Roth notifications@github.com wrote:

A sample app for this library would be fantastic. (of course, along with the usual suspects like a maven pom.xml and the addition of gradle files).

Maybe you could re-organize the project into

/ /library /sample

Similar to https://github.com/JakeWharton/Android-ViewPagerIndicator/. Then see how to go from there. :)

— Reply to this email directly or view it on GitHubhttps://github.com/kennydude/zxing-lib/issues/4 .

— Reply to this email directly or view it on GitHub.

kennydude commented 11 years ago

Portrait may have some issues, but for a warehouse it's fine :)

It's crap the code as it does need tidying up On 15 Jul 2013 02:01, "Sebastian Roth" notifications@github.com wrote:

Not that I want to place rants in your project... but:

My colleague and me never understood the real reason behind the entire qr-only-as-intent decision. We have fragments now and it can't be that hard to migrate. It would open up huge flexibility for lots of apps.

Most importantly, the user experience with intents is not optimal.

  • I cannot change the overlay
  • I cannot control whether a qr code is acceptable to return to the app (think of a warehouse inventory scanning app)
  • on that note, scanning 20 codes really fast means 20 times clicking
  • The qr intent is in landscape, while my app is in portrait (maybe only me but wtf)
  • it breaks program flow and branding

Yes this might be 0.001% of the usecases.

Hence I for hope for this library. I'll take a look into the code soon. :-) Thanks for this project anyway.

On Jul 14, 2013, at 22:09, Joe Simpson notifications@github.com wrote:

I could do, but this whole project is a mess really :')

It's main purpose was to embed scanning in my apps as it would have been tricky to work with Intents.

99.999% of cases should use Intents

On 14 July 2013 15:04, Sebastian Roth notifications@github.com wrote:

A sample app for this library would be fantastic. (of course, along with the usual suspects like a maven pom.xml and the addition of gradle files).

Maybe you could re-organize the project into

/ /library /sample

Similar to https://github.com/JakeWharton/Android-ViewPagerIndicator/.

Then see how to go from there. :)

— Reply to this email directly or view it on GitHub< https://github.com/kennydude/zxing-lib/issues/4> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/kennydude/zxing-lib/issues/4#issuecomment-20947978 .