search

kennygrant / gohackernews

Golang News - curated links about the Go programming language
https://golangnews.com
MIT License
283 stars 42 forks source link

scripts in db/migrate appear to use mysql syntax but Readme.MD refers to Postgres #34

Open nzrower opened 5 years ago

nzrower commented 5 years ago

scripts in db/migrate appear to use mysql syntax but Readme.MD refers to Postgres

nzrower commented 5 years ago

I don't know how the one time initial setup works in detail, but it appears to behave differently if there are .json files in secrets folder vs there not being there.

When I deleted the offending msql db scripts in folder db/migrate and also had no files in secrets folder I got the sever to run by go run server.go

Leaving issue open to see if the primary authors who know what was intended for this have ideas for improving this.

kennygrant commented 5 years ago

The scripts in db/migrate use standard sql where possible, the problem is that the migrate command calls the psql binary to run the migrations. Thus at the moment it is limited to use with postgresql unless you want to run migrations yourself. See fragmenta/migrate.go. So that's why psql is mentioned.

Not really an issue if you're fine running the sql yourself against your db.