search

kennylevinsen / wldash

Wayland launcher/dashboard
https://sr.ht/~kennylevinsen/wldash
GNU General Public License v3.0
186 stars 16 forks source link

Configurable font #15

Closed Mel34 closed 4 years ago

Mel34 commented 5 years ago

Awesome work with adding configuration file!

In the light of the new and exciting configurable wldash, could the font face also be configurable please?

kennylevinsen commented 5 years ago

I'll look into it. Don't know how troublesome it would be to search for and load fonts, plus the configuration necessary to do it.

It is not just font selection that is hardcoded, the fonts themselves are compiled into wldash for simplicity.

Mel34 commented 5 years ago

I see. Installed fonts can be queried, font paths are standardized, so it's more beneficial not to ship fonts bundled with the program but instead use system fonts.

kennylevinsen commented 5 years ago

There are both pros and cons.

Pro is configurability and smaller binary size.

Con is runtime dependencies, increased startup time (no idea how much), and possible issues with font loading and compatibility ("standardized" is a strong word to use in the Linux world. :) ).

I'll look into it, but no idea how much work it will be.

LiHRaM commented 4 years ago

I would like to look into this, specifically by using a fontconfig-enabled crate, such as font-kit. Currently they don't support rusttype, but I think we can patch that upstream.

kennylevinsen commented 4 years ago

Closed by https://github.com/kennylevinsen/wldash/pull/30.