kennym / cf7-to-api

LOOKING FOR MAINTAINER. Wordpress plugin to transmit contact form 7 entries to remote API using POST or GET
https://wordpress.org/plugins/cf7-to-api-basic-auth/
52 stars 30 forks source link

Fix boolean fields in json for acceptance fields #40

Closed NCS-Thomas closed 3 years ago

NCS-Thomas commented 3 years ago

Acceptance fields are parsed to invalid json. The fields were represented: string 1 for true and an empty string for false. This is not in line with the json specs (https://json-schema.org/understanding-json-schema/reference/boolean.html).

The proposed fix check if a field is an acceptance field. If so it will map value to be a string representation of boolean value.

kennym commented 3 years ago

LGTM thanks