kennytm / cargo-kcov

Cargo subcommand to run kcov to get coverage report on Linux
127 stars 19 forks source link

--no-fail-fast has no effect #16

Open kw217 opened 7 years ago

kw217 commented 7 years ago

Hi,

If there is a failing test, I expected cargo kcov --no-fail-fast to generate a coverage report anyway. However instead it reports

error: failed to get coverage
caused by: exit code: 101

and does not generate a coverage report.

I think if --no-fail-fast is specified, the return code from kcov should be ignored in Cmd::run_kcov.