search

kennytv / kennytvs-epic-force-close-loading-screen-mod-for-fabric

https://modrinth.com/mod/forcecloseworldloadingscreen
MIT License
57 stars 5 forks source link

"fix" issue #23 #24

Closed AnOpenSauceDev closed 11 months ago

AnOpenSauceDev commented 1 year ago

No idea if you want to keep the insanely long mod name, but issue #23 happens because there is no space for the "Client" badge on Mod Menu, so it just removes the badge so the text wont spill into the rest of the menu. This PR fixes that (at least in full-screen) by ruining the mod's name by shortening it.

kennytv commented 1 year ago

Hmmmm that's a difficult compromise to make

AnOpenSauceDev commented 1 year ago

Hmmmm that's a difficult compromise to make

Major breaking change imo, unsure whether merging is a wise move.

AnOpenSauceDev commented 1 year ago

Out of curiosity, i tried writing a basic mixin that would force-render the badge no matter what, but because of the drawing order, it ends up getting covered. Looks like there isn't a way to fix this without removing the long name :pensive:.

[!NOTE] The top is with the mixin, the bottom is without. Screenshot from 2023-11-04 12-28-45

AnOpenSauceDev commented 11 months ago

After some deliberation, I have realized that merging would irreversibly tarnish this mod, and that cannot happen. Closing.