search

kenotron / gatsby-starter-uifabric

MIT License
13 stars 0 forks source link

Hot update fails when index.tsx is changed #2

Open ronaldborman opened 5 years ago

ronaldborman commented 5 years ago

If I make a simple textual change to index.tsx (of a freshly generated site without modifications) and HMR kicks in, the following error appears:

hot update was not successful: (LinkBase, ) TypeError: Cannot read property 'render' of undefined

The problem seems the same as https://github.com/OfficeDev/office-ui-fabric-react/issues/9097. When I apply the workaround mentioned there (downgrading react-hot-loader to 4.6.3) the problem disappears.

kenotron commented 5 years ago

It seems to work on my laptop. However, maybe we have different platforms? I have tested this on a Mac only. Do you happen to remember if you were on a Windows machine?

kenotron commented 5 years ago

Hmmm I've seen it fail and succeed on Windows... I've gotten to work on Windows again just now with an updated react-hot-loader@4.9.0. Can you give this another shot, @ronaldborman ?

ronaldborman commented 5 years ago

@kenotron I should have mentioned that I was on Windows 10 beforehand... I've just created a new Gatsby site and upgraded react-hot-loader to version 4.9.0 (and checked node-modules to be certain). Unfortunately, the problem is still there. When I downgrade to version 4.6.3, to problem disappears again.

arvindsinghms commented 5 years ago

@kenotron it would be a great help, if you can provide some update on this issue.