search

kenperkins / winston-papertrail

Papertrail transport for Winston
MIT License
203 stars 94 forks source link

Clarify winston compatibility #79

Open henhal opened 6 years ago

henhal commented 6 years ago

I've been using winston-papertrail with winston 1.1.2 for some time, working fine. However, a module requiring winston 2.1.1 resulted in winston.transports not being assigned Papertrail as a transport. It seems to work to use the returned constructor from winston-papertrail directly, it seems only the injection of winston.transports.Papertrail as the constructor seems to fail.

I saw another issue about winston 3.0 breaking changes, but is it known/expected that winston-papertrail also breaks with 2.x?

markdascher commented 6 years ago

It should definitely work in winston 2.1.1, and I just tested that exact version. No problems using new winston.transports.Papertrail. And this has been there from the beginning, so even an older version of winston-papertrail should be fine.

Is it possible that two different versions of winston are being used simultaneously? If the module has its own private copy of 2.1.1 then I could imagine some weirdness like this.