kenperlin / chalktalk

MIT License
2.12k stars 137 forks source link

Remove THREE.js dependency #27

Open devinmcgloin opened 7 years ago

devinmcgloin commented 7 years ago

As it looks like we're working towards removing THREE.js as a dependency (#22).This issue breaks that out into its own issue with a listing of sketches so we can update progress.

I am unsure of the state of Ken's replacement for THREE.js, so I'll leave it to others as to how to proceed.

Kronopath commented 7 years ago

As part of the work towards #22, @kenperlin and I sat down and did an audit on which sketches to remove or could use a rewrite, and part of that was seeing which sketches use THREE.js.

The sketches that use THREE.js are as follows:

Several of these sketches (hypershape, molecule, net, octopus, and stickman) use the Graph object for their rendering, which will likely need be rewritten in the Chalktalk renderer (and ideally moved to sketchlibs as well, since it's just used in sketches and doesn't need to be in the core).

But many other of these sketches will almost certainly be removed. I'm leaving it up to Ken to make the final call here, since we don't want to delete any sketches that he's currently actively using, but that will help with the migration effort off of THREE.js.

devinmcgloin commented 7 years ago

Great, thanks for the additional information.

It looks like Ken already removed a good chunk of those sketches. If the list I posted initially isn't up to date feel free to update it with the sketches I missed.

I created this mostly as a way to keep track of the progress we are making, as I don't know enough about the chalktalk internals to make a PR.

Kronopath commented 7 years ago

Alright then, I'll update the list in the first post.

KTRosenberg commented 6 years ago

@Kronopath What is the status on this effort?

Kronopath commented 6 years ago

Still open for contribution. The ones that are checked off above have been either migrated or removed, but the unchecked ones still use THREE.js.