search

kenpratt / erlbrake

Erlang Airbrake notification client
http://github.com/kenpratt/erlbrake
MIT License
32 stars 21 forks source link

Rewrite error_logger handler and clean up Airbrake API interface. #10

Closed betawaffle closed 12 years ago

betawaffle commented 12 years ago

I've got a project that's been limping along with the existing implementation for a while now. I finally found some time to rewrite it!

Now it pulls out more useful information about the errors (thanks lager!), and does primitive rate-limiting, so that I don't miss anything. The rate-limiting is hard-coded at 60 per minute, but feel free to implement a more comprehensive solution.

Criticism welcome!

[EDIT] Forgot to mention, this currently supports a very important production application.

[EDIT 2] Also, this does a pretty good job of separating error that are different. However, it doesn't attempt to group the error message, error report, and crash reports for the same error (if you wanted that...)

ddossot commented 12 years ago

@kenpratt did you review this pull request?

My plan is to tag the current master HEAD as "0.2", then pull and bump the current version to "0.3". Green light?

kenpratt commented 12 years ago

Okay, this is merged into master (old version tagged, version bumped to 0.3).

The only hiccup was that this patch depended on the lager_trunc_io module, so rather than introduce a dependency on lager, I cloned it into an erlbrake_trunc_io module.

Thanks for all the work, Andrew!

betawaffle commented 12 years ago

Oh yea, forgot about that.