Allow to use different configurations in parallel

kenpratt / wikipedia-client

Ruby client for the Wikipedia API

http://github.com/kenpratt/wikipedia-client

MIT License

307 stars 76 forks source link

Allow to use different configurations in parallel #99

Closed maltesa closed 3 years ago

maltesa commented 3 years ago

I need to run multiple clients with different configurations. As I understand the current implementation the configuration is a "global" singleton class. Hence, each instance of Client uses the same Instnace of Configuration. With this pull request, I tried to fix that without breaking the original API.

pietromenna commented 3 years ago

Thank you for your contribution! Looks good to me. How can we ensure that the new configurations are validated by automated tests?