kensanata / bitlbee-mastodon

A Mastodon plugin for Bitlbee
https://alexschroeder.ch/software/Bitlbee_Mastodon
GNU General Public License v2.0
30 stars 7 forks source link

build process non-portable #38

Closed velartrill closed 4 years ago

velartrill commented 4 years ago

the current build process relies on a number of GNU extensions, to GNU make, bash, and sed. the upshot is that it does not compile on FreeBSD (or presumably other BSDs, such as Mac OS X). this is a simple fix - references to sh need to be replaced with explicit references to bash (including implicit references - /bin/sh is the default shell used by BSD make; on linux /bin/sh is a link to bash but on FreeBSD is the bourne shell binary), references to sed need to be replaced with references to GNU sed, which may be gsed or sed — this is automatically detected by autotools.

note when a makefile is built with gmake rather than BSD make, it appears to use bash as its default shell - if we can depend on the user installing and using gmake, we only need to worry about sed, a fix for which i'm including in an upcoming PR. however, it may be best to fix the build process to simply remove the GNU extensions, as they appear to have been involved accidentally and unnecessarily.