search

kensanata / mastodon-archive

Archive your statuses, favorites and media using the Mastodon API (i.e. login required)
https://alexschroeder.ch/software/Mastodon_Archive
GNU General Public License v3.0
358 stars 33 forks source link

Prepare v1.4.3 #90

Closed IzzySoft closed 1 year ago

IzzySoft commented 1 year ago

As discussed here, please do check and confirm, but do not yet merge. Once you say it's ready, I first need to push the packages so README.md does not lie :zany_face:

IzzySoft commented 1 year ago

PS: Do you think virtualenv should be mentioned – at least as a hint/pointer? See e.g. this guide.

kensanata commented 1 year ago

PS: Do you think virtualenv should be mentioned – at least as a hint/pointer? See e.g. this guide.

I think for serious Python developers, that's probably true. To my chagrin, however, confess to not using virtualenv. I only have this one Python project I'm working on.

kensanata commented 1 year ago

Sounds good to me!

kensanata commented 1 year ago

Converted to a draft so I don't merge by mistake. :laughing:

IzzySoft commented 1 year ago

@kensanata hope you don't forget about it now because it's still draft :scream: Mind reviewing my above comments?

kensanata commented 1 year ago

It is on my todo list for the weekend. Thanks for the reminder.

kensanata commented 1 year ago

As discussed here, please do check and confirm, but do not yet merge. Once you say it's ready, I first need to push the packages so README.md does not lie zany_face

It's ready. :laughing:

I'm going to look at the exact wording around pip . and python setup.py at some other date. Let's get this out, first.

IzzySoft commented 1 year ago

OK, so we take the current state, and I prepare the packages incl. pushing them to my repo then.

IzzySoft commented 1 year ago

Die Katze ist aus dem Sack! Ugh: Done, DEB and RPM are available in my repo now. So please go ahead with merge & tag – I'm curious if tagging the new version will send me a notification (once I know I'll check RELEASE.md if it needs an update).

kensanata commented 1 year ago

It is done! Thanks for all the energy you invested in this!

IzzySoft commented 1 year ago

Yeeha! Shall we toot it? And oops, at least ONE of the changes we should have done: python setup.py install (append the missing last word). Will you please?

kensanata commented 1 year ago

I understood you to say that the "install" was optional, no?

kensanata commented 1 year ago

As for tooting: you do the tooting and I will boost it. You did the work, after all! :smile:

IzzySoft commented 1 year ago

I understood you to say that the "install" was optional, no?

Reference comment:

OK, so my line is not correct.

With python setup.py the install must be appended as far as I understood. It's not optional. But you have the option to use pip . instead – maybe that's what you mean? All the references I've seen say python setup.py install. Most importantly, the official documentation says so. Our discussion was just about whether to use that or pip – and I voted to mention this one as there might be systems (and use cases) where pip is not present/wanted. But the syntax should be fixed :wink:

PS: no need to re-tag I guess. But it should be adjusted.

IzzySoft commented 1 year ago

Fix included with #91 – so thanks for your patience, we're done here in this PR. I'll now go update the corresponding issue.