kensanata / oddmuse6

Oddmuse wiki engine based on Perl 6 and Cro
GNU Affero General Public License v3.0
3 stars 2 forks source link

Tests are failing on latest zef and rakudo #16

Closed Altai-man closed 4 years ago

Altai-man commented 4 years ago
  ~ zef install Oddmuse6
===> Searching for: Oddmuse6
===> Searching for missing dependencies: Algorithm::Diff
===> Testing: Algorithm::Diff
===> Testing [OK] for Algorithm::Diff
===> Testing: Oddmuse6:ver<0.0.4>:auth<kensanata>
[Oddmuse6] ===SORRY!===
[Oddmuse6] Could not find Oddmuse::Storage::File::Test at line 17 in:
[Oddmuse6]     file#/home/koto/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4
[Oddmuse6]     file#/home/koto/.zef/store/Algorithm--Diff.git/3e2e24b4757506885a6ea6539d5f40c092389aa9
[Oddmuse6]     inst#/home/koto/.perl6
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/site
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/vendor
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/core
[Oddmuse6]     ap#
[Oddmuse6]     nqp#
[Oddmuse6]     perl5#
[Oddmuse6] ===SORRY!===
[Oddmuse6] Could not find Oddmuse::Storage::File::Test at line 17 in:
[Oddmuse6]     file#/home/koto/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4
[Oddmuse6]     file#/home/koto/.zef/store/Algorithm--Diff.git/3e2e24b4757506885a6ea6539d5f40c092389aa9
[Oddmuse6]     inst#/home/koto/.perl6
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/site
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/vendor
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/core
[Oddmuse6]     ap#
[Oddmuse6]     nqp#
[Oddmuse6]     perl5#
[Oddmuse6] ===SORRY!===
[Oddmuse6] Could not find Oddmuse::Storage::File::Test at line 17 in:
[Oddmuse6]     file#/home/koto/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4
[Oddmuse6]     file#/home/koto/.zef/store/Algorithm--Diff.git/3e2e24b4757506885a6ea6539d5f40c092389aa9
[Oddmuse6]     inst#/home/koto/.perl6
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/site
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/vendor
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/core
[Oddmuse6]     ap#
[Oddmuse6]     nqp#
[Oddmuse6]     perl5#
[Oddmuse6] ===SORRY!===
[Oddmuse6] Could not find Oddmuse::Storage::File::Test at line 17 in:
[Oddmuse6]     file#/home/koto/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4
[Oddmuse6]     file#/home/koto/.zef/store/Algorithm--Diff.git/3e2e24b4757506885a6ea6539d5f40c092389aa9
[Oddmuse6]     inst#/home/koto/.perl6
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/site
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/vendor
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/core
[Oddmuse6]     ap#
[Oddmuse6]     nqp#
[Oddmuse6]     perl5#
[Oddmuse6] ===SORRY!===
[Oddmuse6] Could not find Oddmuse::Storage::File::Test at line 17 in:
[Oddmuse6]     file#/home/koto/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4
[Oddmuse6]     file#/home/koto/.zef/store/Algorithm--Diff.git/3e2e24b4757506885a6ea6539d5f40c092389aa9
[Oddmuse6]     inst#/home/koto/.perl6
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/site
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/vendor
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/core
[Oddmuse6]     ap#
[Oddmuse6]     nqp#
[Oddmuse6]     perl5#
[Oddmuse6] ===SORRY!===
[Oddmuse6] Could not find Oddmuse::Storage::File::Test at line 17 in:
[Oddmuse6]     file#/home/koto/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4
[Oddmuse6]     file#/home/koto/.zef/store/Algorithm--Diff.git/3e2e24b4757506885a6ea6539d5f40c092389aa9
[Oddmuse6]     inst#/home/koto/.perl6
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/site
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/vendor
[Oddmuse6]     inst#/home/koto/.rakudobrew/versions/moar-master/install/share/perl6/core
[Oddmuse6]     ap#
[Oddmuse6]     nqp#
[Oddmuse6]     perl5#
kensanata commented 4 years ago

Rebuilding and installing:

cd ~/rakudo
./perl6 -version
This is Rakudo Star version 2019.03.1 built on MoarVM version 2019.03
implementing Perl 6.d.
make install
...
zef install --/test cro
...
zef install Oddmuse6
===> Searching for missing dependencies: Text::Markdown, Algorithm::Diff, HTML::Escape, URI::Encode, Cro::HTTP::Test, DOM::Tiny
===> Testing: Cro::HTTP::Test:ver<0.8.0>
===> Testing [OK] for Cro::HTTP::Test:ver<0.8.0>
===> Testing: DOM::Tiny:ver<0.5.2>:auth<github:zostay>
===> Testing [OK] for DOM::Tiny:ver<0.5.2>:auth<github:zostay>
===> Testing: HTML::Escape:ver<0.0.1>
===> Testing [OK] for HTML::Escape:ver<0.0.1>
===> Testing: Algorithm::Diff
===> Testing [OK] for Algorithm::Diff
===> Testing: Text::Markdown:ver<1.1.0>:auth<github:retupmoca>
===> Testing [OK] for Text::Markdown:ver<1.1.0>:auth<github:retupmoca>
===> Testing: URI::Encode:ver<0.08>
===> Testing [OK] for URI::Encode:ver<0.08>
===> Testing: Oddmuse6:ver<0.0.4>:auth<kensanata>
Type check failed in binding to parameter '$high'; expected Any but got Mu (Mu)
  in sub _replaceNextLargerWith at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 56
  in block  at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 191
  in sub _longestCommonSubsequence at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 179
  in sub _longestCommonSubsequence at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 150
  in sub LCSidx at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 422
  in sub compact_diff at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 431
  in method new at /home/alex/.zef/store/Algorithm--Diff.git/8b2e8084a05a586d65ca2e01e33989bc086c9b71/lib/Algorithm/Diff.pm (Algorithm::Diff) line 496
  in sub refine at /home/alex/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4/lib/Oddmuse/Diff.pm6 (Oddmuse::Diff) line 106
  in sub diff at /home/alex/.zef/store/Oddmuse-0.0.4.tar.gz/Oddmuse-0.0.4/lib/Oddmuse/Diff.pm6 (Oddmuse::Diff) line 86
  in block <unit> at t/diff.t line 61

===> Testing [FAIL]: Oddmuse6:ver<0.0.4>:auth<kensanata>
Aborting due to test failure: Oddmuse6:ver<0.0.4>:auth<kensanata> (use --force-test to override)

Looks like a problem with Algorithm::Diff? I installed my own (old) fork of Algorithm::Diff and now it works.

alex@melanobombus:~$ cd src/Algorithm--Diff/
alex@melanobombus:~/src/Algorithm--Diff$ git remote -v
origin  git@github.com:kensanata/Algorithm--Diff.git (fetch)
origin  git@github.com:kensanata/Algorithm--Diff.git (push)
alex@melanobombus:~/src/Algorithm--Diff$ git pull
Already up to date.
alex@melanobombus:~/src/Algorithm--Diff$ zef install .
===> Testing: Algorithm::Diff
===> Testing [OK] for Algorithm::Diff
===> Installing: Algorithm::Diff
alex@melanobombus:~/src/Algorithm--Diff$ zef install Oddmuse6
===> Searching for: Oddmuse6
===> Searching for missing dependencies: Text::Markdown, HTML::Escape, URI::Encode, Cro::HTTP::Test, DOM::Tiny
===> Testing: HTML::Escape:ver<0.0.1>
===> Testing [OK] for HTML::Escape:ver<0.0.1>
===> Testing: Text::Markdown:ver<1.1.0>:auth<github:retupmoca>
===> Testing [OK] for Text::Markdown:ver<1.1.0>:auth<github:retupmoca>
===> Testing: URI::Encode:ver<0.08>
===> Testing [OK] for URI::Encode:ver<0.08>
===> Testing: Cro::HTTP::Test:ver<0.8.0>
===> Testing [OK] for Cro::HTTP::Test:ver<0.8.0>
===> Testing: DOM::Tiny:ver<0.5.2>:auth<github:zostay>
===> Testing [OK] for DOM::Tiny:ver<0.5.2>:auth<github:zostay>
===> Testing: Oddmuse6:ver<0.0.4>:auth<kensanata>
===> Testing [OK] for Oddmuse6:ver<0.0.4>:auth<kensanata>
===> Installing: HTML::Escape:ver<0.0.1>
===> Installing: Text::Markdown:ver<1.1.0>:auth<github:retupmoca>
===> Installing: URI::Encode:ver<0.08>
===> Installing: Cro::HTTP::Test:ver<0.8.0>
===> Installing: DOM::Tiny:ver<0.5.2>:auth<github:zostay>
===> Installing: Oddmuse6:ver<0.0.4>:auth<kensanata>

If you can figure out what I need to change to make it work again, I'd appreciate any help.

kensanata commented 4 years ago

Please note the known bugs and the link to issue #12 for Algorithm::Diff, if you're going to look into this.

kensanata commented 4 years ago

Looks like the Algorithm::Diff problem I was running into was commit 8b2e8084a05a586d65ca2e01e33989bc086c9b71, and that the follow-up commits should have fixed this. I'm not sure why these weren't installed on my system. I see now that you've used 3e2e24b4757506885a6ea6539d5f40c092389aa9 which is the latest commit, so as far as I can tell, it should work for you. Thus, I'm not sure my issue is the same as your issue.

My output looks very different so I guess I cannot reproduce.

Altai-man commented 4 years ago

This is Rakudo Star version 2019.03.1 built on MoarVM version 2019.03 Are you on Windows? Can you try out 2019.11 on gnu/linux, which is the latest?

kensanata commented 4 years ago

I don’t follow the news all that much. https://raku.org/downloads/ says 2019.03 is the right version? Where do I get a later one?

Altai-man commented 4 years ago

Hmm, indeed, rakudo star bundle release is only on 03... For the newer versions, there are packages for common linux distros available at https://nxadm.github.io/rakudo-pkg/ Or you'd need to install a fresh version using some tool like p6env, rakudup, rakudobrew. Anyway, I'll try to fix it later and will PR a fix, so don't think much about it. Sorry for the noise.

kensanata commented 4 years ago

OK, thanks.

kensanata commented 4 years ago

It works for me, now. If it also works for you, I guess we can close this issue, @Altai-man?

Altai-man commented 4 years ago

Sure, thanks for your time!