search

kensanata / sitelen-mute

a static image gallery creator
https://alexschroeder.ch/software/Sitelen_Mute
GNU General Public License v3.0
75 stars 7 forks source link

More concise Perl style; verbosity levels; use hashes and anonarrays … #8

Closed 0-ast-0 closed 6 years ago

0-ast-0 commented 6 years ago

More legwork: these were thing I would have changed had I not wanted the pkgsrc diff to remain small.

We have better debugging with -vvv now.

I follow Perl Best Practices an dmake sure the code passes percritic. For that reason all the shift commands are now gone (for example).

kensanata commented 6 years ago

I'm going to merge anyway because I like it and because I'm not quite sure what do about the wide character warnings.

0-ast-0 commented 6 years ago

On Tue, Mar 13, 2018 at 06:23:37AM +0000, Alex Schroeder wrote:

kensanata commented on this pull request.

-p do not automatically include full-sized panoramas

  • -d do not generate a full album download
  • -d do not create a full album ZIPfile for download

How about just calling it a zip file? Isn't that common usage these days?

Yes you're right, fixed.