kensho-technologies / bubs

Keras Implementation of Flair's Contextualized Embeddings
Apache License 2.0
26 stars 9 forks source link

padding mode, compute mask, more simple batch indexing #22

Closed pinesnow72 closed 3 years ago

pinesnow72 commented 3 years ago

For the issues below I raised and you replied, I opened this pull request.

19 #20 #21

ydovzhenko commented 3 years ago

Awesome! I'll get back to you in a bit; need to figure out why the tests aren't running.

ydovzhenko commented 3 years ago

Could you add the following to the PR:

I'm working out the issue with new build not being triggered meanwhile - we can work in parallel on these.

pinesnow72 commented 3 years ago

Could you add the following to the PR:

I'm working out the issue with new build not being triggered meanwhile - we can work in parallel on these.

Ok, I forgot to modify unit tests and will modify them soon. I will add some code snippet to some existing unit tests for checking prepad=False and prepad=True In addition, I will remove char_to_int.py. Instead of it, I will add code (methods) to extract char_to_int dictionary (charmap) from Flair embeddings and store it into a pickle. And then that pickle would be loaded and passed to InputEncoder.