search

kensho-technologies / graphql-compiler

Turn complex GraphQL queries into optimized database queries.
Apache License 2.0
553 stars 50 forks source link

Type hint split query #988

Closed chewselene closed 3 years ago

chewselene commented 3 years ago

Adds type hints to graphql_compiler/schema_transformation/split_query.py. Also converts namedtuple to dataclass.

codecov[bot] commented 3 years ago

Codecov Report

Merging #988 (ce18589) into main (f32b9da) will increase coverage by 0.06%. The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   94.29%   94.36%   +0.06%     
==========================================
  Files         113      113              
  Lines        8868     9044     +176     
==========================================
+ Hits         8362     8534     +172     
- Misses        506      510       +4
Impacted Files Coverage Δ
...phql_compiler/schema_transformation/split_query.py 97.15% <97.67%> (+0.38%) :arrow_up:
graphql_compiler/schema_transformation/utils.py 95.26% <100.00%> (-0.45%) :arrow_down:
graphql_compiler/typedefs.py 100.00% <100.00%> (ø)
...schema_generation/sqlalchemy/scalar_type_mapper.py 68.62% <0.00%> (-2.81%) :arrow_down:
graphql_compiler/deserialization.py 97.29% <0.00%> (-0.08%) :arrow_down:
graphql_compiler/compiler/helpers.py 93.81% <0.00%> (ø)
graphql_compiler/schema/schema_info.py 89.58% <0.00%> (ø)
graphql_compiler/interpreter/typedefs.py 0.00% <0.00%> (ø)
graphql_compiler/query_formatting/common.py 97.87% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f32b9da...ce18589. Read the comment docs.