search

kensho-technologies / graphql-compiler

Turn complex GraphQL queries into optimized database queries.
Apache License 2.0
550 stars 50 forks source link

Implement scalar renaming and suppression #993

Closed LWprogramming closed 3 years ago

LWprogramming commented 3 years ago

Previously, schema renaming focused exclusively on allowing the renaming and suppression of object types and their fields. Since future datasets may have other GraphQL definitions (e.g. scalar types), this PR clears away some code that previously worked as a stopgap measure to exclusively focus on object types and fields.

In a separate, future PR (time permitting), I plan to continue cleaning up some of the technical debt involving error reporting for renamings for the built-in scalars as well (so I haven't fully removed the whole _ensure_no_unsupported_scalar_operations function here).

codecov[bot] commented 3 years ago

Codecov Report

Merging #993 (e53cacd) into main (d6c0df5) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #993      +/-   ##
==========================================
- Coverage   94.36%   94.35%   -0.01%     
==========================================
  Files         113      113              
  Lines        9067     9060       -7     
==========================================
- Hits         8556     8549       -7     
  Misses        511      511
Impacted Files Coverage Δ
graphql_compiler/schema_transformation/utils.py 95.13% <ø> (-0.13%) :arrow_down:
...ql_compiler/schema_transformation/rename_schema.py 99.65% <100.00%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6c0df5...e53cacd. Read the comment docs.