search

kensho-technologies / graphql-compiler

Turn complex GraphQL queries into optimized database queries.
Apache License 2.0
553 stars 50 forks source link

Update python-mysqldb package name for Ubuntu 20.04 #997

Closed LWprogramming closed 3 years ago

LWprogramming commented 3 years ago

Our scripts use ubuntu-latest, which is migrating from 18.04 to 20.04. The package python-mysqldb in 18.04 has been renamed to python3-mysqldb in 20.04. This PR makes that update for our CI scripts.

codecov[bot] commented 3 years ago

Codecov Report

Merging #997 (5fd54fd) into main (34c968b) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   94.33%   94.33%   -0.01%     
==========================================
  Files         113      113              
  Lines        9073     9070       -3     
==========================================
- Hits         8559     8556       -3     
  Misses        514      514
Impacted Files Coverage Δ
...ql_compiler/schema_transformation/rename_schema.py 99.64% <100.00%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a3ffe2...5fd54fd. Read the comment docs.

LWprogramming commented 3 years ago

I've looked into the Codecov issue and it looks like the combination of several things happening in a really unfortunate way:

  1. PR #994 was fine while in its separate branch but then CI ran into an intermittent (possibly network-related) issue after it was merged into main. The failed CI means that Codecov never got a report for the main branch after #994 was merged.
  2. Opening this PR means Codecov has no base commit report to compare this PR to, so Codecov is reporting incorrect results because to Codecov this PR (#997) appears two PRs ahead of main (because it includes #994 and #997).
  3. I tried fixing this by re-running the CI on main, but that doesn't work for the same reason this PR (#997) exists-- because the CI environment has gone from Ubuntu 18.04 to 20.04, so the package installation scripts that currently exist need to get changed.

It looks fine to me though, despite what Codecov says. Just didn't want to cause any confusion about the seemingly-failing test. :)