Make linters fix by default

kensho-technologies / pyctcdecode

A fast and lightweight python-based CTC beam search decoder for speech recognition.

Apache License 2.0

422 stars 89 forks source link

Make linters fix by default #6

Closed poneill closed 3 years ago

gkucsko commented 3 years ago

hm, fixing pytoml makes sense (though i was pretty sure it was using it by default anyways) but what's the idea behind removing diff and check only?

poneill commented 3 years ago

hm, fixing pytoml makes sense (though i was pretty sure it was using it by default anyways) but what's the idea behind removing diff and check only?

oops yeah you're right about the black config thing, turns out I was just confused by a venv issue.

Seems like if black or isort catch errors, there's really no case where you wouldn't want to fix them. But we could just have a --fix flag instead if you'd rather.

gkucsko commented 3 years ago

yeah but does that work in CI? don't think the bot can run tests and just add the fix to the commit...

poneill commented 3 years ago

yeah but does that work in CI? don't think the bot can run tests and just add the fix to the commit...

No, definitely not, it's just for local development. I'll just add a --fix flag to preserve compatibility.