Add warning message when a spawn pool is used

kensho-technologies / pyctcdecode

A fast and lightweight python-based CTC beam search decoder for speech recognition.

Apache License 2.0

416 stars 89 forks source link

Add warning message when a spawn pool is used #78

Closed falcaopetri closed 1 year ago

falcaopetri commented 2 years ago

This PR proposes a warning message to the behavior introduced in #68, so users won't be caught off guard about performance differences during batch decoding in different platforms.

lopez86 commented 2 years ago

Tests failed due to an unrelated issue, will try again once that is fixed. See https://github.com/kensho-technologies/pyctcdecode/pull/79

lopez86 commented 2 years ago

@falcaopetri Can you update your branch with the latest updates? that hopefully will fix the broken tests and then this can be merged.

falcaopetri commented 1 year ago

Sure. I've rebased it with main to keep it a clean PR. The broken test seems ok now in my local setup.

Btw, I remember running lint.sh before submitting, but now I see that tests are executed separately in the workflow config. Maybe an addition to CONTRIBUTING.md would be the instructions to run lint and pytest locally.

Let me know if there's something missing, and thanks for the project!