kenshoo / react-multi-select

A Multi Select component built with and for React
https://kenshoo.github.io/react-multi-select
MIT License
120 stars 53 forks source link

node-gyp is no longer needed; clicking on group titles toggles the selection #175

Closed XimitGaia closed 2 years ago

XimitGaia commented 4 years ago

Proposed Changes

liorheber commented 4 years ago

Hi,

Thank you very much for your contribution. You seem to be adding multiple features under the same pull request which I rather we avoid to ensure we can easily review, test and rollback each change.

I didn't go over the whole PR due to that but a few quick comments -

  1. This change requires an upgrade of the node version the project uses.
  2. extracting the style to an external css is a breaking change and should be treated as such.

I'm happy to see through these changes but if you want to push them, please split this PR into separate PRs, each introducing a singular feature or change and we can review and merge them one by one.

Thanks again!