search

kensnyder / quill-image-drop-module

A module for Quill rich text editor to allow images to be pasted and drag/dropped into the editor.
214 stars 78 forks source link

[custom-handler] Allow specifying a custom file reader handler #22

Open kensnyder opened 5 years ago

stargazing-dino commented 5 years ago

File reading is not my thing but would this line

const blob = file.getAsFile ? file.getAsFile() : file;

be better served before the fileReader callback is checked for and called? That way we can be semi sure a File is returned in the callback instead of an Item?

kensnyder commented 5 years ago

@Nolence Let me update the PR.

kensnyder commented 5 years ago

@Nolence have a look now.

zachzoup commented 5 years ago

Is this going to be merged? Doesn't seem to be any issues but it's been almost three months.