The login process can take a couple of seconds before actual results show up, especially now that we have the auth-guard in place.
A loading indicator should be started before the login is sent and then needs to be stopped in the following cases:
1 - the login fails
2 - the login succeeds and the user observable has fired
It is not clear to me yet where the second case most cleanly belongs. The auth-guard seems like the wrong place, and it certainly does not belong in each and every page. This may take some thought.
The login process can take a couple of seconds before actual results show up, especially now that we have the auth-guard in place.
A loading indicator should be started before the login is sent and then needs to be stopped in the following cases:
1 - the login fails 2 - the login succeeds and the user observable has fired
It is not clear to me yet where the second case most cleanly belongs. The auth-guard seems like the wrong place, and it certainly does not belong in each and every page. This may take some thought.