fix: number enum are filtered

[smackgg]

like this enum shouldn't be filtered

 Joi.object({
    code: Joi.string()
      .valid([1, 2, 3])
      .required(),
  });

[kenspirit]

I wonder why the code is string type but valid value is provided with number.

[smackgg]

Joi.object({
    code: Joi.number()
      .valid([1, 2, 3])
      .required(),
  });

the same issue

@kenspirit number will be return true when use _.isEmpty https://github.com/lodash/lodash/issues/496

.isEmpty(null) // => true .isEmpty(undefined) // => true .isEmpty(true); // => true .isEmpty(false); // => true .isEmpty(1); // => true .isEmpty(0); // => true

[kenspirit]

Yes, I am considering that just now. It should be a more generic fix instead of just for number.

[smackgg]

In fact, enum always number/string

[kenspirit]

In fact, enum always number/string

@smackgg Sometimes, we might want to set the field to be null, empty string or 0. According to the spec, enum should be array with unique element value of any type.

I wonder if this filtering logic should be removed.

[kenspirit]

@smackgg Issue is fixed by this commit. Version 2.2.4 is released. Thanks for finding out the issue.