Can I use auto-assign bot with Github teams?

kentaro-m / auto-assign

🤖 A Probot app that adds reviewers to pull requests when pull requests are opened.

https://probot.github.io/apps/auto-assign/

ISC License

249 stars 55 forks source link

Can I use auto-assign bot with Github teams? #102

Open mrlubos opened 4 years ago

mrlubos commented 4 years ago

Hi! I am just exploring the auto-assign bot and I see I can configure groups to assign for reviews. However, these have to be defined in the config file. Since we already manage our groups in Github teams, would it be possible to reference only the Github team names in the config? Or is this an already existing feature? Thanks!

kentaro-m commented 4 years ago

Hi, @mrlubos! Thanks for waiting. The auto-assign bot is not supported to assign reviewers to the pull request using GitHub teams now. This topic has been discussed in https://github.com/kentaro-m/auto-assign/issues/39 and https://github.com/kentaro-m/auto-assign/issues/71.

Currently, It is hard to spend time on improving this tool. I have no plan to implement the feature. But improving features by creating the PR is always welcome.

mrlubos commented 4 years ago

Thanks for the reply @kentaro-m!

Is there any recommended workaround? For example, automatically generating the configuration file?

If not, we might look into creating a pull request. Would you have any pointers how to go about implementing this functionality within the auto-assign bot?

Thank you!

okgolove commented 4 years ago

This would be a great feature!

kwangsooshin commented 4 years ago

Awesome!

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

okgolove commented 4 years ago

Do not close, please

mrlubos commented 4 years ago

Hi everyone! I created a pull request adding this functionality in #120, I would appreciate your feedback!

matheusnascgomes commented 4 years ago

Are you guys sure whether it's properly working? Because when i try, the log goes okay, but no reviewers are added to the reviewers list on the right side of the PR page.

@mrlubos @kentaro-m

mrlubos commented 4 years ago

Hey @matheusnascgomes, nice catch! 😃 Yes, it doesn't appear to be working for me either, I will need to look into why that is.

adipatel commented 4 years ago

igabesz commented 4 years ago

I just tried this within our team and it does not work. I tried the @OrgName/team-name and the /team-name syntax in the auto_assign.yml file, neither one added the teams as reviewers. .github/auto_assign.yml:

addReviewers: true

reviewers:
    - /team-a
    - /team-b

numberOfReviewers: 0

We also use a .github/CODEOWNERS file, and it works fine, the owner team is added for review, and their approve is required for the merge.

*   @Org/team-c

alexandrulesi commented 3 years ago

vicsufer commented 3 years ago

Any updates on this?