search

kentaro-m / auto-assign

🤖 A Probot app that adds reviewers to pull requests when pull requests are opened.
https://probot.github.io/apps/auto-assign/
ISC License
249 stars 55 forks source link

missing "numberOfReviewers" key should add all reviewers #107

Closed eltonlauhk01 closed 4 years ago

eltonlauhk01 commented 4 years ago

Describe the bug missing "numberOfReviewers" in auto_assign.yml should add all reviewers

To Reproduce Steps to reproduce the behavior:

  1. have .github/auto_assign.yml with no "numberOfReviewers" key, in default branch
  2. create pull request

Expected behavior missing "numberOfReviewers" in auto_assign.yml should add all reviewers according to README, default: 0

Additional context https://github.com/kentaro-m/auto-assign/blob/43fa337a4fbee2a5866779cffa418b1d6f33d118/src/util.ts#L15 if (desiredNumber === 0) { should be if (!desiredNumber || desiredNumber === 0) {

https://github.com/kentaro-m/auto-assign/blob/43fa337a4fbee2a5866779cffa418b1d6f33d118/src/auto_assign.ts#L42

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

spaceemotion commented 4 years ago

We're observing the same problem, is there a way to fix this despite the wontfix tag?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.