search

kentaro-m / auto-assign

🤖 A Probot app that adds reviewers to pull requests when pull requests are opened.
https://probot.github.io/apps/auto-assign/
ISC License
249 stars 55 forks source link

Check PR body for skipKeywords #119

Open swac opened 4 years ago

swac commented 4 years ago

Is your feature request related to a problem? Please describe.

Our team uses this this action heavily, but we'd like the ability to override the auto-assignment for certain PRs, in particular ones where a developer knows precisely who should review a PR. Right now we often have to remove an auto-assigned reviewer, which creates unnecessary notifications. The existing skipKeywords feature only appears to check the PR title instead of also checking the PR body, which means we're forced to alter our PR title, and thus our squashed commit message title, just to conform to this action's requirements.

Describe the solution you'd like

Either skipKeywords should check the PR's body for matching keywords or there should be a separate skipBodyKeywords feature that matches based on body text.

Describe alternatives you've considered

We can continue working around this by manually removing reviewers.

Additional context

I'm mostly interested in knowing whether this feature is something you think is valuable. If it is, I'm happy to send a PR to make the change 😄

mrlubos commented 4 years ago

What do you think @kentaro-m?

If I had to guess @swac, I think @kentaro-m would be open to a pull request. I opened one and he's been responsive, so I'd say go for it!