search

kentaro-m / auto-assign

🤖 A Probot app that adds reviewers to pull requests when pull requests are opened.
https://probot.github.io/apps/auto-assign/
ISC License
250 stars 54 forks source link

Adds assignee list override #37

Closed colindean closed 6 years ago

colindean commented 6 years ago

Fixes #36

Note that I took a quick stab at this having never worked in Typescript previously. Running npm run build and npm start seemed to work, so I'm hoping that the build system caught any errors I may have introduced because I don't have the bandwidth to set everything up to test it.

Typescript is pretty neat, especially when using vim-polyglot and I got syntax highlighting and linting in the editor without having to configure a thing!

kentaro-m commented 6 years ago

@colindean Thanks for your feature request and PR.

I'd like to accept your changes as much as possible, but since this application is already being used by some users, I would like to be compatibility with a current version.

Currently, I am checking compatibility. If you are in a hurry, try the application self-hosting.

c.f. Running the application with self-hosting https://github.com/kentaro-m/auto-assign#glitch

colindean commented 6 years ago

Thanks for taking a look. I'm not in a hurry at the moment.

colindean commented 6 years ago

Would it facilitate merging if I instead put the use of the attendees list behind a flag, defaulting to false, where true uses the new behavior and false falls back to the old behavior of using the reviewers list?

kentaro-m commented 6 years ago

@colindean I have confirmed your changes, so I merged. Thanks. By the way, I did not notice that the test failed, because the CircleCI build was not working by my mistake. I would like to create a PR to add tests on your changes.