search

kentaro-m / auto-assign

🤖 A Probot app that adds reviewers to pull requests when pull requests are opened.
https://probot.github.io/apps/auto-assign/
ISC License
250 stars 54 forks source link

Error: Review cannot be requested from pull request author. #50

Closed kentaro-m closed 6 years ago

kentaro-m commented 6 years ago

Describe the bug The pull request owner was requested as reviewers. But, it is unable to request a review from the pull request owner on the specification of GitHub.

https://developer.github.com/v3/pulls/review_requests/#create-a-review-request

Currently, if failed to review request, throw an error and exit process. As a result, not add assignees to pull request.

https://github.com/kentaro-m/auto-assign/blob/8079dce25bf00a4339b2405971925102e2fccfa3/src/handler.ts#L42-L55

To Reproduce This error was confirmed from the sentry log, it is not what I actually experienced.

Expected behavior The pull request owner is not requested as reviewers.

kentaro-m commented 6 years ago

https://github.com/kentaro-m/auto-assign/pull/51 Add assignees even if failed to add reviewers.

But it is not a fundamental solution. Probably the pull request owner has been requested to review. Related: https://github.com/kentaro-m/auto-assign/issues/48

kentaro-m commented 6 years ago

This error has been not occurred since #51 had merged, so I closed this issue.