Closed giuseppeg closed 6 years ago
Merging #24 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #24 +/- ##
======================================
Coverage 41.6% 41.6%
======================================
Files 21 21
Lines 411 411
Branches 62 62
======================================
Hits 171 171
Misses 201 201
Partials 39 39
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e3faeba...c740755. Read the comment docs.
During the workshop I noticed that you were using a combo of
input
+button
in theSwitch
component to toggle state. This PR is a small refactoring to make it accessible to screen readers. In the original version I found the following issues:display: none
so it is not focusable and screen readers couldn't read it. I made it visually hidden (see the css file).checked
state, that's why I had to tweak the test utils/extension.input
was just used for its native switch nature (checked/unchecked) to update theSwitch
state, but it was controlled by a button - better use a label for that.✌️☮️