search

kentcdodds / advanced-react-patterns-v2

Created with CodeSandbox
https://codesandbox.io/s/github/kentcdodds/advanced-react-patterns-v2
1.51k stars 567 forks source link

Encode the email before using it as a URL parameter #46

Closed gpetrioli closed 6 years ago

gpetrioli commented 6 years ago

My email contains a + character which in URLs means a space. So in order to maintain it (and other valid characters that have special meaning when in URLs) we need to pass the email through encodeURIComponent before using it as a URL parameter.

codecov[bot] commented 6 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   39.67%   39.67%           
=======================================
  Files          22       22           
  Lines         431      431           
  Branches       66       66           
=======================================
  Hits          171      171           
  Misses        217      217           
  Partials       43       43

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e983e1f...9f7c76b. Read the comment docs.