Closed norchow closed 5 years ago
Merging #60 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 39.67% 39.67%
=======================================
Files 22 22
Lines 431 431
Branches 66 66
=======================================
Hits 171 171
Misses 217 217
Partials 43 43
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 944d371...23cf88e. Read the comment docs.
@all-contributors please add @norchow for tests
@kentcdodds
I've put up a pull request to add @norchow! :tada:
Hi,
Doing the training at Frontend Masters, i run into an issue where my code passed the spec but it wasn't working as expected.
Basically, if in exercise one, you don't toggle the
on
value, but you just set it totrue
, the tests were passing. The solution could look like:I've just added a new spec, to test this behaviour. Let me know what you think.