search

kentcdodds / babel-plugin-macros

🎣 Allows you to build simple compile-time libraries
https://npm.im/babel-plugin-macros
MIT License
2.62k stars 135 forks source link

Pass options to cosmiconfig according to 5.x.x API #100

Closed lPadier closed 5 years ago

lPadier commented 5 years ago

What: I've updated babel-plugin-macros' usage of cosmiconfig to use the 5.x.x API.

Why: This project's dependency on cosmiconfig was updated from 4.x.x to 5.x.x, but without changing the calls to cosmiconfig.

Thus, the configuration override was no longer being read (packageProp was not overridden, thus using babelMacros in package.json no longer worked).

The tests still passed as they only checked babel-plugin-macros.config.js, which was read by default by cosmiconfig: https://github.com/davidtheclark/cosmiconfig#searchplaces

codecov[bot] commented 5 years ago

Codecov Report

Merging #100 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #100   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          79     79           
  Branches       18     18           
=====================================
  Hits           79     79
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ad592c...6a8cc1f. Read the comment docs.