kentcdodds / babel-plugin-macros

🎣 Allows you to build simple compile-time libraries

https://npm.im/babel-plugin-macros

MIT License

2.62k stars 135 forks source link

use babel traverse #156

Closed JoviDeCroock closed 4 years ago

JoviDeCroock commented 4 years ago

Resolves: https://github.com/kentcdodds/babel-plugin-macros/issues/121

This uses @babel/traverse rather than the stateful one

JoviDeCroock commented 4 years ago

@kentcdodds sorry the pre-commit script seems to crash on windows 😅

codecov[bot] commented 4 years ago

Codecov Report

Merging #156 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           97        98    +1     
  Branches        22        22           
=========================================
+ Hits            97        98    +1

Impacted Files	Coverage Δ
src/index.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 727459f...c74e247. Read the comment docs.

kentcdodds commented 4 years ago

Oh no! Sorry about that! If you could figure out why that would be a great help 😅

Thanks for this change!

kentcdodds commented 4 years ago

Is this PR still a draft or is it ready to be merged?

JoviDeCroock commented 4 years ago

It seems good, I'll take a look what the issue is

kentcdodds commented 4 years ago

@all-contributors please add @JoviDeCroock for code and tests

allcontributors[bot] commented 4 years ago

@kentcdodds

I've put up a pull request to add @JoviDeCroock! :tada:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: