kentcdodds / babel-plugin-macros

🎣 Allows you to build simple compile-time libraries

https://npm.im/babel-plugin-macros

MIT License

2.62k stars 135 forks source link

Revert d5d44a6 to fix regression #165

Closed conartist6 closed 3 years ago

conartist6 commented 3 years ago

Fixes #164, a regression of https://github.com/kentcdodds/import-all.macro/issues/7.

We need a test for the regression so that it doesn't break again, and (assuming this is still the right fix for the original issue) also we will have to find a different fix for the issue I have reopened, #121.

codecov[bot] commented 3 years ago

Codecov Report

Merging #165 (caa5e74) into master (ccc43ec) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          131       130    -1     
  Branches        38        38           
=========================================
- Hits           131       130    -1

Impacted Files	Coverage Δ
src/index.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ccc43ec...caa5e74. Read the comment docs.

ben-rogerson commented 3 years ago

Hey Kent, it'd be awesome if you could patch this in - it'll fix some errors I'm seeing in twin.macro.

kentcdodds commented 3 years ago

Oh, it's still a draft PR. I think @conartist6 wanted to write a regression test for it. @ben-rogerson world you like to help with that yourself?

conartist6 commented 3 years ago

It's mergeable, with or without the regression test. The fact that every set of pushed changes is release though makes it harder for me to imagine that the test will be added in the future if it isn't added now though.

kentcdodds commented 3 years ago

I definitely don't have time to add a test for it myself. I'm pretty much at the "quick review and merge if people say it's ok" stage of maintaining this package 😬 (https://kcd.im/no-time).

conartist6 commented 3 years ago

@ben-rogerson Do you mind contributing that fix? I may have time to do it over the next few days, but also I may not. You're the only one who seems to be directly affected by the possibility of a regression. If you'd rather just get the fix in now, I'm fine with that.

kentcdodds commented 3 years ago

We don't have many changes in this repo, so I think I'll go ahead and merge this now. @ben-rogerson if you'd like to make sure this never breaks in the future, please contribute a test. Thanks!

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: