kentcdodds / babel-plugin-macros

🎣 Allows you to build simple compile-time libraries

https://npm.im/babel-plugin-macros

MIT License

2.62k stars 135 forks source link

support more extensions that babel macros can be written in #175

Closed quantizor closed 3 years ago

quantizor commented 3 years ago

What:

Babel macros that are written in typescript and not transpiled prior to being run through babel-plugin-macros are currently not detected because resolve defaults to only looking for the ".js" extension.

quantizor commented 3 years ago

@kentcdodds would love to get this in if possible, I'm converting styled-components to TS and testing our babel macro written in TS is proving challenging without this

codecov[bot] commented 3 years ago

Codecov Report

Merging #175 (d77b3c8) into main (d613985) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          130       130           
  Branches        38        38           
=========================================
  Hits           130       130

Impacted Files	Coverage Δ
src/index.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d613985...d77b3c8. Read the comment docs.

kentcdodds commented 3 years ago

@all-contributors please add @probablyup for code

allcontributors[bot] commented 3 years ago

@kentcdodds

I've put up a pull request to add @probablyup! :tada:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

quantizor commented 3 years ago

@kentcdodds thanks for taking this so quickly!