search

kentcdodds / bookshelf

Build a ReactJS App workshop
https://www.epicreact.dev/modules/build-an-epic-react-app-v1/build-an-epic-react-app-welcome
Other
2.66k stars 1.17k forks source link

Replace broken link in INSTRUCTIONS #232

Closed AngadSethi closed 2 years ago

AngadSethi commented 2 years ago

Hi @kentcdodds, the link pointing to ReactQueryConfigProvider in the documentation for react-query version 2 is broken. The documentation for the provider is not currently available on the website, so maybe it would be a better idea to direct the reader to the source markdown file instead?

kentcdodds commented 2 years ago

@all-contributors please add @AngadSethi for docs

allcontributors[bot] commented 2 years ago

@kentcdodds

I've put up a pull request to add @AngadSethi! :tada:

AngadSethi commented 2 years ago

Oops, I didn't go through the contribution guide before opening a PR. Thanks for merging @kentcdodds!

kentcdodds commented 2 years ago

You didn't do anything wrong. I was just explaining why I had to close the PR instead of actually merge it 😅 Thanks!