search

kentcdodds / generator-kcd-oss

A yeoman generator for my open source modules
http://yeoman.io/
MIT License
138 stars 28 forks source link

fix: Add types reference in package.json #47

Closed MichaelDeBoey closed 3 years ago

MichaelDeBoey commented 3 years ago

I've always seen it added to the package.json, so I don't think so but I'm not 100% sure

kentcdodds commented 3 years ago

I'm pretty sure it's not needed.

MichaelDeBoey commented 3 years ago

type-fest has it too: https://github.com/sindresorhus/type-fest/blob/master/package.json#L43

I can look into other packages if you want.

kentcdodds commented 3 years ago

Based on this it looks like we should, so we will.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 4.10.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: