search

kentcdodds / jest-glamor-react

Jest utilities for Glamor and React
https://npm.im/jest-glamor-react
MIT License
98 stars 24 forks source link

Move glamor to a dev dependency #21

Closed hjylewis closed 6 years ago

hjylewis commented 6 years ago

What: Move glamor to a dev dependency

Why: Moving glamor to a dev dependency avoids a bug where jest-glamor-react uses a different instance of glamor than the parent package resulting in an empty stylesheet.

How: Remove glamor as a normal dependency and add as a dev dependency

Should address #20

hjylewis commented 6 years ago

The custom-sheet.test.js is failing for me. Can someone try it on their machine after a clean npm install?

@kentcdodds

codecov[bot] commented 6 years ago

Codecov Report

Merging #21 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          65     65           
  Branches       13     13           
=====================================
  Hits           65     65

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a88ab95...15172c0. Read the comment docs.