kentcdodds / jest-glamor-react

Jest utilities for Glamor and React
https://npm.im/jest-glamor-react
MIT License
98 stars 24 forks source link

Fix processing rules with additional appended classes, i.e. &.someclass #22

Closed asvetliakov closed 7 years ago

asvetliakov commented 7 years ago

What: Fix the output when css rule have only something like this:

  &.active {
    background:green;
  }

Previously it was skipped from output due to wrong filtering in getStyles()

How: See getStyles in serializer.js in PR

codecov[bot] commented 7 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          65     66    +1     
  Branches       13     14    +1     
=====================================
+ Hits           65     66    +1
Impacted Files Coverage Δ
src/serializer.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84ace7c...6e7c86a. Read the comment docs.

kentcdodds commented 7 years ago

Would you like to add yourself to the contributors table?

kentcdodds commented 7 years ago

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

asvetliakov commented 7 years ago

Thanks! I'll add myself to the table