search

kentcdodds / js-mocking-fundamentals

JavaScript Mocking Fundamentals on TestingJavaScript.com
https://testingjavascript.com/courses/javascript-mocking-fundamentals
Other
306 stars 286 forks source link

Add comments to fn #4

Closed libersolis-dev closed 4 years ago

libersolis-dev commented 4 years ago

This pull request:

Adds comments to fn() to document function signature

kentcdodds commented 4 years ago

Thanks for the PR. Because this isn't really a workshop, I don't have instructions like I do for some of my other material. So I don't think I'll merge this, but thanks anyway :)

libersolis-dev commented 4 years ago

Wow. I have no memory of submitting this PR or why I would have submitted it. The only thing I can guess is that it was done via vscode accidentally, which is still wierd because I write all my git stuff from the command line in an external terminal.

I am more willing to submit a legit PR at some point after seeing how cool you were about something like this!